Skip to content

Conversation

@cku328
Copy link
Contributor

@cku328 cku328 commented Jul 1, 2020

What changes were proposed in this pull request?

Fixed and enabled this test cases.

Added configuration of rpc and watch timeouts for RATIS client & server.
Called the wait method waitForPipelineTobeReady to ensure that at least one RATIS pipeline in open state.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3440

How was this patch tested?

Manual unit test 120 times -> Tests passed.

image

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cku328 for fixing this. 50/50 tests passed.

FYI I'm trying to convert these config settings to type-safe as part of #1106.

@adoroszlai adoroszlai merged commit 9e0f5ba into apache:master Jul 1, 2020
@cku328
Copy link
Contributor Author

cku328 commented Jul 2, 2020

Thanks @adoroszlai for merging this.
For #1106 commit, do I need to modify this test case?

@adoroszlai
Copy link
Contributor

For #1106 commit, do I need to modify this test case?

No, thanks, I've already updated it in 809a1e2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants